Gdrive folder select #5
Conversation
Added an option to change which GDrive folder the screenshot is saved to. Uses an HTML <select> tag to populate a list of folders in the users GDrive.
This reverts commit 8dd5733.
Uses the GDrive API to let a user select the folder he/she wants to save the screenshot into. Uses an HTML <select> tag to populate a list of folders and subfolders
I changed the <select> tag code so that choosing a folder would populate the tag with subfolder options, an option to use the current folder's "root", and an option to go up a folder. Basic file traversal for picking a GDrive folder
method once, instead of having a different call under each scenario in the if/else branch.
|
sorry for the delay in review, finally got to it and i like what i see. pretty neat way of dealing with hierarchical folders, good job! this is pretty much ok to merge, other than formatting: can you please make the new code match existing style? namely, tabs -> spaces, tab stop = 2 instead of 8. |
|
oh, and please remove "folder select" from the html page, it's pretty obvious what the dropdown is. |
- Converted tabs to 2 spaces - Removed the "Folder select" text from `edit.html`
|
I committed the changes you prescribed above. Glad I could contribute to the extension (it's my first pull request and project I've ever used Github with). Thanks a lot! |
|
ok Josh, this looks good, i'm merging it. thanks again for your work! this will go out with the next beta (once i finish some refactoring i've been doing around full page captures). |
Re-opening the pull request I had earlier. I modified the UI code to be more user-friendly, though it's still slightly flawed. I like this approach much better than what I had before; it imitates the Google Drive Picker more closely.