Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for SecurityCapabilities tag in XML files #356

Closed
Hedreon opened this issue Sep 6, 2023 · 1 comment · Fixed by #359
Closed

Support for SecurityCapabilities tag in XML files #356

Hedreon opened this issue Sep 6, 2023 · 1 comment · Fixed by #359
Labels
module: rbx_binary module: rbx_reflector module: rbx_types module: rbx_xml type: enhancement New feature or request

Comments

@Hedreon
Copy link

Hedreon commented Sep 6, 2023 •
edited

Roblox recently implemented the SecurityCapabilities tag and because of this new implementation, Rojo can't build projects with the SecurityCapabilities tag in any roblox XML files.
@Hedreon Hedreon changed the title Support for SecurityCapabilities in .rbxmx files Support for SecurityCapabilities in .rbxmx files Sep 6, 2023
@Hedreon Hedreon changed the title Support for SecurityCapabilities in .rbxmx files Support for SecurityCapabilities tag in XML files Sep 9, 2023
@kennethloeffler
Copy link
Member

rbx-dom is able to process files containing SecurityCapabilities. There's a warning because the type is unknown, and the decoded representation will not contain properties of this type, but it doesn't totally prevent usage. If SecurityCapabilities does grind everything to a halt right now (it doesn't in my testing), then there's a bug we need to fix.

I'll get started on this. Thanks for the report!

@kennethloeffler kennethloeffler mentioned this issue Sep 16, 2023
Merged
Dekkonot pushed a commit that referenced this issue Sep 18, 2023
@kennethloeffler
Add rbx_xml SecurityCapabilites parsing, add to reflection (#359)
8a013f1 
Closes #356 

This PR adds `SecurityCapabilities` support to rbx_xml and adds
reflection information for `SecurityCapabilities`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: rbx_binary module: rbx_reflector module: rbx_types module: rbx_xml type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add rbx_xml SecurityCapabilites parsing, add to reflection kennethloeffler/rbx-dom
2 participants
@kennethloeffler @Hedreon