Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the baseplate and added texture #593

Closed
wants to merge 3 commits into from

Conversation

VillaErnest
Copy link

@VillaErnest VillaErnest commented Jul 27, 2022

  • Updated the baseplate size and position
  • Added the default baseplate texture

Before
RobloxScreenShot20220727_210718096

After
RobloxScreenShot20220727_210736830

@Kampfkarren
Copy link
Member

Class names are not necessary. It's good the default project format doesn't falsely teach that it is.

I could've sworn the other changes have been denied in the past, but can't find the PR.

@VillaErnest
Copy link
Author

VillaErnest commented Jul 27, 2022

Class names are not necessary. It's good the default project format doesn't falsely teach that it is.

I could've sworn the other changes have been denied in the past, but can't find the PR.

I see, I added the class names because Selene is giving me the warning to do so.

@Kampfkarren
Copy link
Member

Not selene, the Rojo extension, which is incorrect.

@VillaErnest
Copy link
Author

Not selene, the Rojo extension, which is incorrect.

Is it possible to silence this warning?

@VillaErnest VillaErnest changed the title Update default place template Changed the baseplate and added texture Jul 27, 2022
@LPGhatguy
Copy link
Contributor

Hello, thanks for the PR!

I think that this is a good change to the default project. However, it also makes the starting default.project.json file a fair bit bigger. A fair number of users complain about the default project having a baseplate, and having that baseplate in the project file is kinda weird.

I think that we should consider making the default project have an rbxm file or model.json containing the baseplate to clear up this clutter.

What do y'all think, @VillaErnest, @Kampfkarren?

@VillaErnest
Copy link
Author

Hello, thanks for the PR!

I think that this is a good change to the default project. However, it also makes the starting default.project.json file a fair bit bigger. A fair number of users complain about the default project having a baseplate, and having that baseplate in the project file is kinda weird.

I think that we should consider making the default project have an rbxm file or model.json containing the baseplate to clear up this clutter.

What do y'all think, @VillaErnest, @Kampfkarren?

I agree, having the baseplate inside the default.project.json file seems weird and out of place. So, making a separate rbxm file should make the default.project.json file less cluttered.

@boatbomber boatbomber added the status: needs review This work is mostly done, but just needs work to integrate and merge it. label Aug 6, 2022
@Dekkonot
Copy link
Member

Dekkonot commented Aug 1, 2024

Closing to clean up old PRs. Sorry! Feel free to re-open if it's still something we need or you want changed.

@Dekkonot Dekkonot closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review This work is mostly done, but just needs work to integrate and merge it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants