Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable spanish support #81

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Conversation

electrocucaracha
Copy link
Contributor

The CNCF glossary project is currently using this action to validate its documentation. There are plans to translate it to different languages, therefore it's necessary to include other languages like Spanish. This change can facilitate the validation process.

@jonasbn jonasbn self-requested a review February 17, 2022 16:32
Copy link
Collaborator

@jonasbn jonasbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. PR approved

@jonasbn jonasbn added this to the 0.22.0 milestone Feb 21, 2022
@jonasbn jonasbn added the enhancement New feature or request label Feb 21, 2022
@jonasbn jonasbn self-assigned this Feb 21, 2022
@jonasbn jonasbn merged commit 0a799fc into rojopolis:master Feb 21, 2022
@jonasbn
Copy link
Collaborator

jonasbn commented Feb 24, 2022

Hi @electrocucaracha I have released 0.22.0 with your changes. All builds passed and all looked well. I later decided to do some more testing. Unfortunately this demonstrated that the functionality your PR was based on was not working as expected. So I have released a bug fix release 0.22.1.

Testing spellchecking of non-english texts is now working, currently supporting German (de) and Spanish (es).

Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants