Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rollup for dist files - create index.umd.min.js to be used directly in the browser #61

Merged
merged 4 commits into from
Nov 4, 2019

Conversation

chregu
Copy link
Contributor

@chregu chregu commented Nov 1, 2019

And autodeploy on tags.

Demo for including it here: https://jsfiddle.net/chregu/m9hcvrqt/

@mweibel
Copy link
Contributor

mweibel commented Nov 4, 2019

the compile npm script uses babel still. Shouldn't we switch all to rollup if we use it anyway?

@chregu
Copy link
Contributor Author

chregu commented Nov 4, 2019

Maybe. Just didn't want to break something. But I can have a look.

@chregu chregu force-pushed the rollup branch 2 times, most recently from 07b8b73 to b10dcc3 Compare November 4, 2019 10:36
@chregu
Copy link
Contributor Author

chregu commented Nov 4, 2019

So, it now does an ESM and CJS file with rollup as well. Seems to work in my setup, but not totally sure it's the right way

@chregu chregu changed the title create index.umd.min.js to be used directly in the browser Use rollup for dist files - create index.umd.min.js to be used directly in the browser Nov 4, 2019
@mweibel
Copy link
Contributor

mweibel commented Nov 4, 2019

looks good to me, without having it checked personally. Shall I merge?

@chregu
Copy link
Contributor Author

chregu commented Nov 4, 2019

let's merge and see what happens ;)

@mweibel mweibel merged commit bacf90d into master Nov 4, 2019
@mweibel mweibel deleted the rollup branch November 4, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants