Fix bug with flagging shadowed stdlib func

rokucommunity · Nov 19, 2020 · 8d1cdef · 8d1cdef
1 parent 1370414
commit 8d1cdef
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Scope.spec.ts b/src/Scope.spec.ts
@@ -297,12 +297,12 @@ describe('Scope', () => {
                 });
             });
 
-            it('detects scope function with same name as built-in function', async () => {
+            it('flags scope function with same name (but different case) as built-in function', async () => {
                 await program.addOrReplaceFile({ src: s`${rootDir}/source/main.brs`, dest: s`source/main.brs` }, `
                     sub main()
                         print str(12345) ' prints 12345 (i.e. our str() function below is ignored)
                     end sub
-                    function str(num)
+                    function STR(num)
                         return "override"
                     end function
                 `);

diff --git a/src/Scope.ts b/src/Scope.ts
@@ -452,7 +452,7 @@ export class Scope {
             if (lowerFuncName) {
 
                 //find function declarations with the same name as a stdlib function
-                if (globalCallableMap.has(func.getName(ParseMode.BrighterScript))) {
+                if (globalCallableMap.has(lowerFuncName)) {
                     this.diagnostics.push({
                         ...DiagnosticMessages.scopeFunctionShadowedByBuiltInFunction(),
                         range: func.nameRange,