You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When #1136 lands, we should consider removing file from the BsDiagnostic interface. It doesn't feel right being attached to a diagnostic, and we could easily update DiagnosticsManager to support returning a new object that includes the scope/file information (i.e. the file) for a diagnostic) if we need that information.
This would be a breaking change, so likely should be done as part of v1.
The text was updated successfully, but these errors were encountered:
Not really sure how this works. How do we associate with a diagnostic with a file? Do we use the Location property on the Diagnostic.relatedInformation?
Then if we need to know what file that diagnostic comes from, that would be an attribute of the return value from the diagnostic manager. Perhaps something like this?:
When #1136 lands, we should consider removing
file
from theBsDiagnostic
interface. It doesn't feel right being attached to a diagnostic, and we could easily updateDiagnosticsManager
to support returning a new object that includes the scope/file information (i.e. the file) for a diagnostic) if we need that information.This would be a breaking change, so likely should be done as part of v1.
The text was updated successfully, but these errors were encountered: