Remove file prop from BsDiagnostic
#1248
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All diagnostics internal to Brighterscript now use a
location: Locationprop instead offile: BscFileThis has a few good points:
Locationfor Tokens and AstNodesOne thing to note is that sometimes we need to back-convert a URI to a path for finding the files that a diagnostic applies to.
There might be some inconsistencies between Operating Systems (Mac vs. Windows, etc) that should be dealt with the
URInamespace fromvscode-uri, but I'm not entirely sure.Addresses: #1155