Support integer type declaration char #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwitchBronBron
commented
Dec 17, 2020
| @@ -792,6 +792,12 @@ describe('lexer', () => { | |||
| }); | |||
|
|
|||
| describe('long integer literals', () => { | |||
| it('respects \'&\' suffix', () => { | |||
There was a problem hiding this comment.
Not directly impacted by this code, but the test for this was missing so I added it.
TwitchBronBron
commented
Dec 17, 2020
| } | ||
|
|
||
| if (designator === '!') { | ||
| } else if (designator === '!') { |
There was a problem hiding this comment.
I combined several separate if statements into one continuous if...else if...else if... block. This cleaned up the code by removing several return statements and making it easier to follow the flow.
TwitchBronBron
commented
Dec 17, 2020
| this.advance(); | ||
| this.addToken(TokenKind.LongIntegerLiteral); | ||
|
|
||
| } else if (designator === '%') { |
There was a problem hiding this comment.
This is the core of the change. we just needed a separate if block for handling %
elsassph
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the BrightScript documentation, a
%can be appended to an integer literal to enforce that it becomes an integer type.Currently bsc shows a syntax error on that trailing
%, so this PR fixes that.Fixes #233