Class annotation support #270
Conversation
…s that appear before a class keyword
|
Good catch - though annotations shouldn't normally be added from inside the statement readers normally. I need to check. |
|
I also see that we're missing it for class methods (at least that seems to be the case): If so, I can add that. If there's a more proper way to implement this, let me know - it's late, and I quickly moved over maestro and rooibos, so I wasn't expecting to jump back into bsc right now, so just did what was expedient. |
src/parser/Parser.ts
Outdated
| @@ -460,6 +463,12 @@ export class Parser { | |||
| parentClassName, | |||
| this.currentNamespaceName | |||
| ); | |||
|
|
|||
| //attach annotations to statements | |||
| if (classAnnotations?.length) { | |||
There was a problem hiding this comment.
While this technically works due to javascripts truthy/falsey, let's check for length > 0
There was a problem hiding this comment.
I got this from other code in the project.. I didn't like it; but I thought it was idiomatic
There was a problem hiding this comment.
Test should be
if (classAnnotations.length > 0) {
and we can merge - I'll complete some other things.
TwitchBronBron
changed the title
|
Got a couple of questions about this. @elsassph says this is working out the box as it stands. I didn't get that behaviour with the above unit test so I'm confused. Secondly I've been told that this should be implemented with refactoring the parser. Don't have time to do that. Can we just make it work for the time being for classes and class methods and do whatever refactoring later? The feature is half baked as it is imho. |
|
I think I've covered everything here - see tests. |
|
I think this is good to go now. I addressed both of your feedback and merged current master. |
Adds annotation support for classes, attaching any pending annotation…s that appear before a class keyword
@elsassph inspired (i.e goaded) me to add annotation support for maestro, perhaps knowing that this feature was missing and I would therefore have to write it :D Great delegation @elsassph 👏
Hopefully this approach is okay - I'm sure we all concur that annotations are just as usefu on classes as other statements.