-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intermediary fix for Roku_Ads error #312
Conversation
} else if ((arg as any).getDiagnostics) { | ||
diagnostics = (arg as any).getDiagnostics(); | ||
} else if ((arg as any).diagnostics) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a test helper function. The Program
object has diagnostics
that are program-specific, but also has a getDiagnostics()
function that rolls up its own diagnostics along with all scopes and files. So we should check for getDiagnostics()
first since that one will be more complete.
@@ -18,6 +19,18 @@ describe('globalCallables', () => { | |||
program.dispose(); | |||
}); | |||
|
|||
describe('Roku_ads', () => { | |||
it('exists', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll update this test once we have formal library support.
Has there been any action on this? I'm trying to use 'Roku_Ads()' within a script file. I've included the Library call at the top. When I call the function, I get: |
Is there a workaround for this issue? When trying to use Roku_Ads() in the same source as the Library statement, I get:
|
Disregard my earlier post. I was able to include Roku_Ads() after reading some of your other posts. |
This is a temporary fix for the fact that
Roku_Ads
is sometimes available globally (dependent on aLibrary
import.Long-term we want to add formal
Library
handling. However, There's a lot of other more important things to work on right now, so this will hold us over until then.Provides temporary relief for #179