Feat/enum completion #485
Merged
Feat/enum completion #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwitchBronBron
force-pushed
the
feat/enum-completion
branch
from
1bcd137
to
8a11418
Compare
TwitchBronBron
requested changes
Jan 16, 2022
TwitchBronBron
force-pushed
the
feat/enum-completion
branch
from
f90c784
to
73a626b
Compare
georgejecook
force-pushed
the
feat/enum-completion
branch
from
6d208c5
to
bf76c71
Compare
|
somethings gone a bit weird here, @TwitchBronBron - I accidentally did the validation work onthis branch, so I dropped that commit and force pushed. hayyylp :) |
|
I reverted that code because it wasn't helpful and didn't solve what we needed. Stick with the walker for now...I'll come up with a more efficient approach later. |
|
@TwitchBronBron updated to use the walker; but it no longer runs. I think it might be a circular reference, issue; but this ts error is beyond me. |
|
Check all your newly added import statements in .ts files and make sure none of them are coming from ".." or "../../". (Without a file name). Those regularly cause circular ref issues. Always import from an exact files. |
TwitchBronBron
approved these changes
Feb 1, 2022
TwitchBronBron
added a commit
that referenced
this pull request
Feb 11, 2022
* Enum support in Lexer * Basic enum parsing support * Parser support for enums. * Baseline enum implementation. * Enum declaration validations * Fix lint issues. * include parent namespace name in enum statements. * Add EnumStatement to findReferences * vscode formatting setting. * Add primaryDottedGetExpressions to _references * Fix primaryDottedGetExpressions * Undo `primaryDottedGetExpressions` * Fix parse errors when enum is at top of file with other content * Adds plugin hooks for file validation * Undo space in settings file * Feat/enum completion (#485) * adds completions for enum types * add tests to prove there are no enum member collisions * Formatting fixes * small var naming tweaks * remove unnecessary eslint disable. * clean up test a little * adds validation for enums * adds completions for enum types * add tests to prove there are no enum member collisions * Formatting fixes * small var naming tweaks * remove unnecessary eslint disable. * clean up test a little * changes namespace.enumStatements to map * changes namespace.enumStatements to map * fixes broken imports * uses visitor to ascertain dotted get statements * fix circular ref issues. * clean up some tests Co-authored-by: Bronley Plumb <bronley@gmail.com> * Feat/enum validation (#486) * adds completions for enum types * add tests to prove there are no enum member collisions * Formatting fixes * small var naming tweaks * remove unnecessary eslint disable. * clean up test a little * adds validation for enums * adds completions for enum types * add tests to prove there are no enum member collisions * Formatting fixes * small var naming tweaks * remove unnecessary eslint disable. * clean up test a little * changes namespace.enumStatements to map * changes namespace.enumStatements to map * fixes broken imports * uses visitor to ascertain dotted get statements * fix circular ref issues. * Expression tracking during parse. * Partial support for re-calculating `references.expressions` * Capture rest of missing expressions. * Fix lint issues. * integrate with `parser.references.expressions` * Remove unnecessary eslint disable comment * Clean up enum tests * clean up some tests Co-authored-by: Bronley Plumb <bronley@gmail.com> * Fire plugin events for getTranspiledFile. Add new event properties * fix lint issues. * Tests for enum transpile. * Don't clear parser._references during enum validate * Fix reflection func for EnumStatement * Add generics support to Cache class. Use map. * Implement enum transpile. * Move file validation into program.validate() * fix lint issues * Fix bug with string enums not transpiling * make test work on node 10 * better validation for unknown enum values * make `getFile` more flexible. * tweaks * Tweaks. * Fix completions case sensitivity but * Fix enum member completions * Fixed some broken enum completions * Fix other broken enum completions * Cache extens map. * Detect duplicate enum declarations * fix lint issues * Remove duplicate tests. Move enum tests into Enum.spec.ts * fix lint issue * Fix unit test indentation bugs * verify all top-level items show in completion * use `setFile` * Fix enum completions * semantic token support for enums * Emit better transpiled enums even with errors * flag non-literal enum values. * Safer enum member access * completions test * Transpile `invalid` for non-literal enums * Add enum docs * remove old launch.json Co-authored-by: George Cook <george@tantawowa.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds completions for enums and enum statements. Works as follows: