Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move parse and validate events out to program level #494

Merged
merged 2 commits into from
Jan 27, 2022

Conversation

TwitchBronBron
Copy link
Member

@TwitchBronBron TwitchBronBron commented Jan 26, 2022

Moves the afterFileParse, onValidateFile, and afterFileValidate events into the Program class and out of BrsFile.ts and XmlFile.ts to make things more consistent.

The changes were mostly done to BrsFile.ts, XmlFile.ts, and Program.ts. The other changes are just unit test tweaks to make them work with the changes (i.e. we need to call program.addOrReplaceFile now instead of using the file.parse() function directly to trigger the plugin event.)

@TwitchBronBron TwitchBronBron merged commit ef62517 into master Jan 27, 2022
@TwitchBronBron TwitchBronBron deleted the program-emits-validation-events branch January 27, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants