Optional chaining #546
Merged
Optional chaining #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdp
reviewed
Apr 1, 2022
chrisdp
reviewed
Apr 1, 2022
arturocuya
reviewed
Apr 1, 2022
chrisdp
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds syntax support for optional chaining. Since the brightscript runtime supports this natively in Roku OS 11, there's no need for any special transpile logic at this time. However, there are significant dangers of crashing in the native implementation, so I think we will still add a transpile step in the future to make this feature more useful.
This PR is just to support the syntax from a parser level.