Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add object and key to visitor callbacks. #600

Merged
merged 4 commits into from
May 26, 2022
Merged

Conversation

TwitchBronBron
Copy link
Member

@TwitchBronBron TwitchBronBron commented May 25, 2022

  • Provides the parent object and the key used to fetch the item from the parent object in AST walk visitor callbacks. This makes AST editing a little easier when it's desired to actually remove the element from the parent AST.
  • update all AST walk methods to support adding/removing items during the walk cycle without messing up the iteration.

Also
Resolves #477

@TwitchBronBron TwitchBronBron merged commit fe47d14 into master May 26, 2022
@TwitchBronBron TwitchBronBron deleted the ast-walk-parent-keys branch May 26, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Walk functionality should return the key path from the parent to the child
2 participants