Fix typescript error for ast parent setting #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwitchBronBron
commented
Aug 4, 2022
| @@ -348,18 +348,6 @@ export class NamespacedVariableNameExpression extends Expression { | |||
| } | |||
| range: Range; | |||
|
|
|||
| // @ts-expect-error override the property | |||
There was a problem hiding this comment.
This comment isn't persisted into the d.ts file, so it causes errors in consumers. That's the whole reason for this PR.
chrisdp
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ts error introduced in #650 introduced that only shows up in the typedef files.
Seems to provide a slight performance boost as well (probably due to the
if (childNode?.parent)check which prevents duplicate reparenting.