Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use outputPath to check if thi is a new file #691

Merged
merged 2 commits into from
Sep 14, 2022
Merged

use outputPath to check if thi is a new file #691

merged 2 commits into from
Sep 14, 2022

Conversation

ZeeD
Copy link
Contributor

@ZeeD ZeeD commented Sep 14, 2022

related to #690

TwitchBronBron
TwitchBronBron requested changes Sep 14, 2022
View reviewed changes
Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Just need to toLowerCase those lookups and then it'll be good to go.

src/Program.ts Outdated Show resolved Hide resolved
src/Program.ts Outdated Show resolved Hide resolved
@ZeeD
use case-insensitive check
6756d1e 
roku fs is case-insensitive
@ZeeD
Copy link
Contributor Author

ZeeD commented Sep 14, 2022

yeah, sorry I forgot to add the .toLowerCase() invocation

@TwitchBronBron TwitchBronBron merged commit ad752b7 into rokucommunity:master Sep 14, 2022
@ZeeD ZeeD mentioned this pull request Sep 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwitchBronBron TwitchBronBron TwitchBronBron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ZeeD @TwitchBronBron