Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: else block with leading comment #712

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Fix: else block with leading comment #712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41998af
Fix transpilation of simple else block with leading comment
elliot-nelson Oct 4, 2022
3b06a81
Merge branch 'master' into enelson/else-block-comment
TwitchBronBron Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/files/BrsFile.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2604,6 +2604,19 @@ describe('BrsFile', () => {
`);
});

it('handles else block with a leading comment', () => {
testTranspile(`
sub main()
if true then
print "if"
else
' leading comment
print "else"
end if
end sub
`);
});

it('works for function parameters', () => {
testTranspile(`
function DoSomething(name, age as integer, text as string)
Expand Down
2 changes: 1 addition & 1 deletion src/parser/Statement.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ export class IfStatement extends Statement {

} else {
//else body
state.lineage.unshift(this.elseBranch);
state.lineage.unshift(this.tokens.else);
let body = this.elseBranch.transpile(state);
state.lineage.shift();

Expand Down