add noProject flag to bsc so BSConfig.json not expected #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philanderson888
changed the title
philanderson888
changed the title
|
Thank you @TwitchBronBron for that clarification - yes I was not sure which way to go, so went for the softer option! Happy to go with the hard stop so if the flag is set, bsconfig.json loading is completely disabled. Happy for you to review the code a second time Thanks All suggestions implemented, just a few changes to comments but other than that as-is as you specified. Please check all code and let me know any faults or amendments, thanks :) |
TwitchBronBron
approved these changes
Sep 18, 2023
|
Thanks @TwitchBronBron happy to help Onwards and upwards to the next one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.