Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow optionally specifying bslib destination directory #871

Merged
merged 1 commit into from
Aug 30, 2023
Merged

allow optionally specifying bslib destination directory #871

merged 1 commit into from
Aug 30, 2023

Conversation

enthooz
Copy link
Contributor

@enthooz enthooz commented Aug 4, 2023

  • Add bslibDestinationDir option.
  • Update README to document new option.
  • Add tests.

@TwitchBronBron
Copy link
Member

@enthooz can you fix the build errors? You can run nom run preversion locally to run the full suite.

@enthooz enthooz force-pushed the feature/bslibDestinationDir-option branch 2 times, most recently from e9ec8ab to bc7eddb Compare August 6, 2023 20:37
@enthooz
Copy link
Contributor Author

enthooz commented Aug 6, 2023

@TwitchBronBron — Done!

@enthooz enthooz force-pushed the feature/bslibDestinationDir-option branch from bc7eddb to f84a2fb Compare August 8, 2023 20:58
@TwitchBronBron TwitchBronBron merged commit 5e7e147 into rokucommunity:master Aug 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwitchBronBron TwitchBronBron TwitchBronBron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@enthooz @TwitchBronBron