Skip to content

Commit

Permalink
Support a configurable port for SceneGraphDebugCommandController (#534)
Browse files Browse the repository at this point in the history
* Add sceneGraphDebugCommandsPort defaults

* Update description for sceneGraphDebugCommandsPort

* roku-deploy@0.20.14

---------

Co-authored-by: Christian Holbrook <dev.ramnage@gmail.com>
Co-authored-by: Bronley Plumb <bronley@gmail.com>
  • Loading branch information
3 people committed Dec 7, 2023
1 parent 8287fa3 commit 45df527
Show file tree
Hide file tree
Showing 3 changed files with 33 additions and 26 deletions.
50 changes: 25 additions & 25 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
"node-ssdp": "^4.0.0",
"postman-request": "^2.88.1-postman.32",
"pretty-bytes": "^5.6.0",
"roku-debug": "^0.20.13",
"roku-debug": "^0.20.14",
"roku-deploy": "^3.11.0",
"roku-test-automation": "2.0.0-beta.22",
"semver": "^7.1.3",
Expand Down Expand Up @@ -830,6 +830,11 @@
"default": false,
"description": "Delete any currently installed dev channel before starting the debug session"
},
"sceneGraphDebugCommandsPort": {
"type": "number",
"default": 8080,
"description": "Port for sending SceneGraph debug commands"
},
"remoteControlMode": {
"oneOf": [
{
Expand Down
2 changes: 2 additions & 0 deletions src/DebugConfigurationProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ export class BrightScriptDebugConfigurationProvider implements DebugConfiguratio
remotePort: 8060,
rendezvousTracking: true,
deleteDevChannelBeforeInstall: false,
sceneGraphDebugCommandsPort: 8080,
remoteControlMode: {
activateOnSessionStart: false,
deactivateOnSessionEnd: false
Expand Down Expand Up @@ -316,6 +317,7 @@ export class BrightScriptDebugConfigurationProvider implements DebugConfiguratio
config.cwd = folderUri.fsPath;
config.rendezvousTracking = config.rendezvousTracking === false ? false : true;
config.deleteDevChannelBeforeInstall = config.deleteDevChannelBeforeInstall === true;
config.sceneGraphDebugCommandsPort = config.sceneGraphDebugCommandsPort ? config.sceneGraphDebugCommandsPort : this.configDefaults.sceneGraphDebugCommandsPort;
if (typeof config.remoteControlMode === 'boolean') {
config.remoteControlMode = {
activateOnSessionStart: config.remoteControlMode,
Expand Down

0 comments on commit 45df527

Please sign in to comment.