fix infinite recursion possibility in Scenegraph Inspector and fix Ro…

…ku Commands list of available requests (#480) Co-authored-by: Brian Leighty <bleighty@tubi.tv> Co-authored-by: Bronley Plumb <bronley@gmail.com>
rokucommunity · May 10, 2023 · 82b7c01 · 82b7c01
1 parent c48d401
commit 82b7c01
Show file tree

Hide file tree

Showing 4 changed files with 54 additions and 34 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -71,7 +71,7 @@
         "pretty-bytes": "^5.6.0",
         "roku-debug": "^0.18.8",
         "roku-deploy": "^3.10.1",
-        "roku-test-automation": "^2.0.0-beta.17",
+        "roku-test-automation": "^2.0.0-beta.19",
         "semver": "^7.1.3",
         "source-map": "^0.7.3",
         "thenby": "^1.3.4",

diff --git a/webviews/src/views/RokuCommandsView/RokuCommandsView.svelte b/webviews/src/views/RokuCommandsView/RokuCommandsView.svelte
@@ -62,14 +62,13 @@
     const commandList = [];
     for (const commandName of odcCommands) {
         let argsKey = commandName.charAt(0).toUpperCase() + commandName.slice(1) + 'Args';
-        const definition = requestArgsSchema.definitions[argsKey];
-        if (!definition) {
-            console.warn(`Could not retrieve definition for ${commandName}`);
-            continue;
+        let definitionArgs = requestArgsSchema.definitions[argsKey] as any[];
+        if (!definitionArgs) {
+            definitionArgs = [];
         }
         commandList.push({
             name: commandName,
-            args: requestArgsSchema.definitions[argsKey]
+            args: definitionArgs
         });
     }
 

diff --git a/webviews/src/views/SceneGraphInspectorView/SceneGraphInspectorView.svelte b/webviews/src/views/SceneGraphInspectorView/SceneGraphInspectorView.svelte
@@ -87,7 +87,8 @@
         const returnFocusedArrayGridChild = utils.getStorageBooleanValue('includeArrayGridChildren', true)
         const { ref } = await odc.getFocusedNode({
             includeRef: true,
-            returnFocusedArrayGridChild: returnFocusedArrayGridChild
+            returnFocusedArrayGridChild: returnFocusedArrayGridChild,
+            includeNode: false
         });
         focusedNode = ref;
     }