Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to capture device screenshots #430

Closed
TwitchBronBron opened this issue Aug 26, 2022 · 1 comment
Closed

Add ability to capture device screenshots #430

TwitchBronBron opened this issue Aug 26, 2022 · 1 comment
Assignees

Comments

@TwitchBronBron
Copy link
Member

roku-deploy supports capturing screenshots since roku-deploy#92. Integrate this functionality into the VSCode extension.

Flow:

  • Trigger "take a screenshot" by
    • Running a command from the command pallet
      • when triggering the command directly, we need to prompt the user to pick which Roku device to use
    • Clicking a button in the "Active Devices" panel
      • the user clicked the button on a specific device, so they don't need to pick a device
  • the image is automatically saved to temp (that's the default way roku-deploy writes it right now)
  • vscode will then open the image in a new tab in preview mode so the user can see it.

Considerations:
Here are some user settings that might make sense:

//should a preview window be shown after every screenshot
"brightscript.screenshots.enablePreview": true | false,

//What screeshot info should be copied to clipboard? The image data itself? The image path? or nothing?
"brightscript.screenshots.copyToClipboard": "image" | "path" | "disabled",

//where should the screenshots be placed? Defaults to the current system temp directory.
"brightscript.screenshot.imageDir": "${workspaceFolder}/.temp/images"
@TwitchBronBron
Copy link
Member Author

This was implmeneted in #505

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants