Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to capture device screenshots #505

Merged
merged 9 commits into from
Oct 12, 2023
Merged

Add ability to capture device screenshots #505

merged 9 commits into from
Oct 12, 2023

Conversation

fumer-fubotv
Copy link
Collaborator

@fumer-fubotv fumer-fubotv commented Oct 9, 2023

  1. Ability to add support for "capture screenshot" through command palette and device view.
  2. Upon success - screenshot preview is shown to user

Detailed issue: #430

@fumer-fubotv fumer-fubotv self-assigned this Oct 9, 2023
1. Added support to show preview of screenshot
2. Fixed a linter issue
Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few tweaks to the password logic flow to make it work better with existing launch.json password, and also fixed a few crashes related to missing passwords. I added an emoji to the tree item to make it stand out more as a command.

This looks great! Thanks for your great work on this.

@TwitchBronBron TwitchBronBron merged commit 2c9fadc into master Oct 12, 2023
5 checks passed
@TwitchBronBron TwitchBronBron deleted the ROKU-1008 branch October 12, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants