Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync launch settings #438

Conversation

philanderson888
Copy link
Contributor

No description provided.

@philanderson888
Copy link
Contributor Author

OK @TwitchBronBron looks like it's passing all tests so over to you ... thanks.

@@ -1592,6 +1595,306 @@
"type": "string",
"description": "A path to a file where all brightscript console output will be written. If null or empty, file logging will be disabled.",
"scope": "resource"
},
"brightscript.debug.host": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these need to have "scope": "resource" added to them. This should happen in the sync-launch-settings.ts script.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes made @TwitchBronBron thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philanderson888 The "scope": "resource" seems to still be missing in these.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes... That will be because I did not re-run the script yet!!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK @TwitchBronBron I have now re-run the script. All of the 'brightscript.debug.' entries now contain "scope":"resource" in them, populated from the script.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@philanderson888
Copy link
Contributor Author

All amendments made - please check again @TwitchBronBron thanks

@TwitchBronBron
Copy link
Member

Looks great! Thanks for this.

@TwitchBronBron TwitchBronBron merged commit e575987 into rokucommunity:master Sep 27, 2022
@philanderson888
Copy link
Contributor Author

OK! Happy to be of help!

@philanderson888 philanderson888 deleted the feature/sync-launch-settings branch September 27, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants