-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync launch settings #438
sync launch settings #438
Conversation
OK @TwitchBronBron looks like it's passing all tests so over to you ... thanks. |
@@ -1592,6 +1595,306 @@ | |||
"type": "string", | |||
"description": "A path to a file where all brightscript console output will be written. If null or empty, file logging will be disabled.", | |||
"scope": "resource" | |||
}, | |||
"brightscript.debug.host": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these need to have "scope": "resource"
added to them. This should happen in the sync-launch-settings.ts script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes made @TwitchBronBron thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@philanderson888 The "scope": "resource"
seems to still be missing in these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes... That will be because I did not re-run the script yet!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK @TwitchBronBron I have now re-run the script. All of the 'brightscript.debug.' entries now contain "scope":"resource" in them, populated from the script.
All amendments made - please check again @TwitchBronBron thanks |
Looks great! Thanks for this. |
OK! Happy to be of help! |
No description provided.