Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with not all connections being deleted when node deleted. #9

Closed
wants to merge 1 commit into from
Closed

Conversation

Teknologicus
Copy link

@Teknologicus Teknologicus commented Aug 17, 2019

First if statement fixes issue with not all connections to node being deleted when node is deleted. Second if statement prevents redundant DeleteConnection() calls from occurring.
0
1
2

First if statement fixes issue with not all connections to node being deleted when node is deleted.  Second issue prevents redundant DeleteConnection() calls from occurring.
@rokups
Copy link
Owner

rokups commented Aug 19, 2019

This does not fix the issue though. Also checks are redundant because conceptually connection should not exist with only one end connected. The only exception is connection that is being created, but user does not deal with that. Anyhow, issue lies somewhere else. Do you plan to revisit and update this PR?

@Teknologicus
Copy link
Author

Teknologicus commented Aug 19, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants