Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Handle service account access tokens #35

Closed
Tracked by #55
roberlander2 opened this issue Mar 4, 2022 · 2 comments · Fixed by #37
Closed
Tracked by #55

[FEATURE] Handle service account access tokens #35

roberlander2 opened this issue Mar 4, 2022 · 2 comments · Fixed by #37
Assignees
@roberlander2
Labels
breaking This issue or pull request introduces breaking changes enhancement New feature or request
Milestone
v1.1.0

Comments

@roberlander2
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The current version of the library is unable to handle multiple service account access tokens.

Describe the solution you'd like
Expand the RemoteAuthDataLoader to store and make requests using multiple access tokens, each corresponding to an app_id, org_id pair.

Describe alternatives you've considered
Access permissions and scopes could be managed using one access token per service account, but this would introduce undesirable complexity into the access tokens.
@roberlander2 roberlander2 added the enhancement New feature or request label Mar 4, 2022
@roberlander2 roberlander2 self-assigned this Mar 4, 2022
@roberlander2 roberlander2 mentioned this issue Mar 14, 2022
Merged
18 tasks
@shurwit
Copy link
Collaborator

shurwit commented Mar 21, 2022

Waiting to finish review on rokwire/core-building-block#306

@shurwit shurwit added blocked and removed blocked labels Apr 8, 2022
@shurwit
Copy link
Collaborator

shurwit commented Apr 8, 2022

Waiting for new API in rokwire/core-building-block#459

@roberlander2 roberlander2 mentioned this issue Apr 18, 2022
Closed
@shurwit shurwit added this to the v1.1.0 milestone May 4, 2022
@roberlander2 roberlander2 mentioned this issue Jun 8, 2022
Closed
6 tasks
@roberlander2 roberlander2 added the breaking This issue or pull request introduces breaking changes label Jun 9, 2022
@roberlander2 roberlander2 mentioned this issue Jun 9, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roberlander2 roberlander2

Labels
breaking This issue or pull request introduces breaking changes enhancement New feature or request
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

[ID-35] Handle service account access tokens rokwire/core-auth-library-go
2 participants
@shurwit @roberlander2