Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add service account unit tests #59

Closed
4 tasks done
Tracked by #55
roberlander2 opened this issue Jun 8, 2022 · 1 comment · Fixed by #60
Closed
4 tasks done
Tracked by #55

[FEATURE] Add service account unit tests #59

roberlander2 opened this issue Jun 8, 2022 · 1 comment · Fixed by #60
Assignees
@roberlander2
Labels
enhancement New feature or request
Milestone
v1.1.0

Comments

@roberlander2
Copy link
Contributor

roberlander2 commented Jun 8, 2022 •
edited

Is your feature request related to a problem? Please describe.
The new service account functionality in the authservice package has no interface tests written for it. These tests should be added to ensure the service account functions will work as expected.

Describe the solution you'd like
Add tests for the following functions:

  • authservice.ServiceAccountManager.GetCachedAccessToken
  • authservice.ServiceAccountManager.GetAccessToken
  • authservice.ServiceAccountManager.GetAccessTokens
  • authutils.ReadResponseBody

Describe alternatives you've considered
The tests do not have to be written for the service account functionality to work correctly, but it is good practice to include the tests to check for correctness in the case of future changes.
@roberlander2 roberlander2 added the enhancement New feature or request label Jun 8, 2022
@roberlander2 roberlander2 added this to the v1.1.0 milestone Jun 8, 2022
@roberlander2 roberlander2 self-assigned this Jun 8, 2022
This was referenced Jun 8, 2022
Merged
Closed
Merged
@roberlander2
Copy link
Contributor Author

Waiting for #35 to be resolved.

@shurwit shurwit removed the blocked label Jun 10, 2022
shurwit added a commit that referenced this issue Jun 10, 2022
@roberlander2 @shurwit
[#59] Add service account unit tests (#60)
16aa9ca 
* start writing service account unit tests

* finish writing service account manager tests

* update changelog

Co-authored-by: Stephen Hurwit <sjhurwit@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roberlander2 roberlander2

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.1.0
2 participants
@shurwit @roberlander2