Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Expose Request parsing functions #65

Closed
roberlander2 opened this issue Aug 12, 2022 · 0 comments · Fixed by #66
Closed

[FEATURE] Expose Request parsing functions #65

roberlander2 opened this issue Aug 12, 2022 · 0 comments · Fixed by #66
Assignees
@roberlander2
Labels
enhancement New feature or request

Comments

@roberlander2
Copy link
Contributor

roberlander2 commented Aug 12, 2022 •
edited

Is your feature request related to a problem? Please describe.
The sigauth package does not expose SignatureAuth.checkRequest or Request.getHeader, both of which would be helpful to users trying to parse the SignatureAuthHeader from a Request.

Describe the solution you'd like
Expose SignatureAuth.checkRequest and Request.getHeader.

Describe alternatives you've considered
Users can perform the same operation as these two sigauth functions using functions that are already exposed, but this would require users to rewrite these functions unnecessarily.
@roberlander2 roberlander2 added the enhancement New feature or request label Aug 12, 2022
@roberlander2 roberlander2 self-assigned this Aug 12, 2022
@roberlander2 roberlander2 changed the title [FEATURE] [FEATURE] Expose Request parsing functions Aug 12, 2022
roberlander2 added a commit that referenced this issue Aug 12, 2022
@roberlander2
expose sigauth request parsing functions, fix deprecations [#65]
547cff4
@roberlander2 roberlander2 mentioned this issue Aug 12, 2022
Merged
18 tasks
@roberlander2 roberlander2 linked a pull request Aug 12, 2022 that will close this issue
[#65] Expose Request parsing functions #66
Merged
18 tasks
shurwit pushed a commit that referenced this issue Aug 16, 2022
@roberlander2
[#65] Expose Request parsing functions (#66)
058217f 
expose sigauth request parsing functions, fix deprecations [#65]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roberlander2 roberlander2

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#65] Expose Request parsing functions rokwire/core-auth-library-go
1 participant
@roberlander2