Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Scope utility functions #70

Closed
roberlander2 opened this issue Oct 18, 2022 · 0 comments · Fixed by #71
Closed

[FEATURE] Scope utility functions #70

roberlander2 opened this issue Oct 18, 2022 · 0 comments · Fixed by #71
Assignees
@roberlander2
Labels
enhancement New feature or request

Comments

@roberlander2
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The list of utility functions that are available for scopes is missing functions that operate on lists of scopes and a function that can return a subset of scopes that are relevant to a given service ID, resource, and operation. There are also no clearly defined scope operation constants (e.g., "get", "update", "create").

Describe the solution you'd like
Add utility functions and constants for scopes that address the above.

Describe alternatives you've considered
These utilities and constants could all be defined by individual services that require them, but this is what the development of the auth library is intended to avoid.
@roberlander2 roberlander2 added the enhancement New feature or request label Oct 18, 2022
@roberlander2 roberlander2 self-assigned this Oct 18, 2022
roberlander2 added a commit that referenced this issue Oct 19, 2022
@roberlander2
add scope list utility functions, move app org pair constants and che…
b1817a1 
…cking to authutils [#70]
@roberlander2 roberlander2 mentioned this issue Oct 19, 2022
Merged
18 tasks
@roberlander2 roberlander2 linked a pull request Oct 19, 2022 that will close this issue
[#70] Scope utility functions #71
Merged
18 tasks
shurwit added a commit that referenced this issue Oct 21, 2022
@roberlander2 @shurwit
[#70] Scope utility functions (#71)
986bc87 
* add scope list utility functions, move app org pair constants and checking to authutils [#70]

* update changelog

* bug fixes

* clean and clarify scope validation logic, add tests

* update dependencies, fix lint issues

* fix scopefromstrings, add tests

* clean up and move GetAccessPairs

* add AppOrgPair CanAccess

* add Scopes function to claims

Co-authored-by: Stephen Hurwit <sjhurwit@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roberlander2 roberlander2

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#70] Scope utility functions rokwire/core-auth-library-go
1 participant
@roberlander2