Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Define TokenAuthHandlers #73

Closed
shurwit opened this issue Nov 11, 2022 · 0 comments · Fixed by #74
Closed

[FEATURE] Define TokenAuthHandlers #73

shurwit opened this issue Nov 11, 2022 · 0 comments · Fixed by #74
Assignees
Labels
enhancement New feature or request

Comments

@shurwit
Copy link
Collaborator

shurwit commented Nov 11, 2022

Is your feature request related to a problem? Please describe.
We set up the TokenAuthHandler system in the Core BB (https://github.com/rokwire/core-building-block/blob/d4faf045aed1c83120886a70f879e6c7dd707c4f/driver/web/auth.go#L132), however other BBs should be implementing similar checks.

Describe the solution you'd like
To enable easy and secure validation of tokens, we should expose the TokenAuthHandler struct and related components in the tokenauth package of this library for use throughout the ecosystem.

Describe alternatives you've considered
The alternative is to have each service implement similar checks internally. This would result in inconsistencies, poor maintainability, and potential security flaws.

@shurwit shurwit added the enhancement New feature or request label Nov 11, 2022
@shurwit shurwit self-assigned this Nov 11, 2022
@shurwit shurwit linked a pull request Nov 14, 2022 that will close this issue
18 tasks
shurwit added a commit that referenced this issue Nov 15, 2022
* define token auth handlers

* update token example, add GetTokenAuth to all handlers

* update dependencies

* fix logging issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant