Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Empty request body on refresh service token in makeRequest #77

Closed
shurwit opened this issue Nov 18, 2022 · 0 comments · Fixed by #78
Closed

[BUG] Empty request body on refresh service token in makeRequest #77

shurwit opened this issue Nov 18, 2022 · 0 comments · Fixed by #78
Assignees
@roberlander2
Labels
bug Something isn't working

Comments

@shurwit
Copy link
Collaborator

shurwit commented Nov 18, 2022 •
edited

Describe the bug
If the makeRequest function requires a refresh to occur, it will call client.Do on the same http.Request object twice. Each call will consume the body of teh request, so the second request will have an invalid empty body.

Expected behavior
The request should be identical before and after the refresh.

Additional Details
On receiving end, error shows as:

Error validating request" error="request body has an error: reading failed: unexpected EOF
@shurwit shurwit added the bug Something isn't working label Nov 18, 2022
roberlander2 added a commit that referenced this issue Nov 21, 2022
@roberlander2
fix request cloning, reset request body after access token refresh [#77]
5ecdcff
roberlander2 added a commit that referenced this issue Nov 21, 2022
@roberlander2
add max tokken refresh frequency error after second 401 [#77]
ca22131
@roberlander2 roberlander2 mentioned this issue Nov 21, 2022
Merged
18 tasks
@roberlander2 roberlander2 linked a pull request Nov 21, 2022 that will close this issue
[#77] Empty request body on refresh service token in makeRequest #78
Merged
18 tasks
roberlander2 added a commit that referenced this issue Nov 22, 2022
@roberlander2
fix bug trying to copy empty request bodies [#77]
d16a193
shurwit pushed a commit that referenced this issue Nov 23, 2022
@roberlander2
[#77] Empty request body on refresh service token in makeRequest (#78)
3ed08cd 
* fix request cloning, reset request body after access token refresh [#77]

* add max tokken refresh frequency error after second 401 [#77]

* update changelog

* fix bug trying to copy empty request bodies [#77]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roberlander2 roberlander2

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#77] Empty request body on refresh service token in makeRequest rokwire/core-auth-library-go
2 participants
@shurwit @roberlander2