Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Function param on base token auth handlers #79

Closed
shurwit opened this issue Nov 22, 2022 · 0 comments · Fixed by #80
Closed

[FEATURE] Function param on base token auth handlers #79

shurwit opened this issue Nov 22, 2022 · 0 comments · Fixed by #80
Assignees
Labels
enhancement New feature or request

Comments

@shurwit
Copy link
Collaborator

shurwit commented Nov 22, 2022

Is your feature request related to a problem? Please describe.
Currently we need to define a separate base auth handler type to handle any required additional checks.

Describe the solution you'd like
We should allow a function to be passed in to the base tokenauth.Handlers that performs the additional checks required.

Describe alternatives you've considered
We could define a separete handler that performs these additional checks in the implementing service and embed a standard handler, however this will lead to inefficiencies in the order of the checks and require additional overhead of defining a handler for each type.

@shurwit shurwit added the enhancement New feature or request label Nov 22, 2022
@shurwit shurwit self-assigned this Nov 23, 2022
@shurwit shurwit linked a pull request Nov 23, 2022 that will close this issue
18 tasks
shurwit added a commit that referenced this issue Nov 23, 2022
* add claims check function param to handlers

* fix typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant