Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Expose invalid claims #94

Closed
shurwit opened this issue Feb 28, 2024 · 0 comments · Fixed by #95
Closed

[FEATURE] Expose invalid claims #94

shurwit opened this issue Feb 28, 2024 · 0 comments · Fixed by #95
Assignees
@shurwit
Labels
enhancement New feature or request

Comments

@shurwit
Copy link
Collaborator

shurwit commented Feb 28, 2024

Is your feature request related to a problem? Please describe.
Currently if the token claims cannot be validated an error is returned without the claims but sometimes it is useful to know what is contained within the invalid claims.

Describe the solution you'd like
We should return the invalid claims along with the validation error when token claims are invalid. This will also mean that it will become critical to make sure that we are properly checking the error before using the claims.
@shurwit shurwit added the enhancement New feature or request label Feb 28, 2024
@shurwit shurwit self-assigned this Feb 28, 2024
@shurwit shurwit mentioned this issue Feb 29, 2024
Merged
18 tasks
@shurwit shurwit linked a pull request Feb 29, 2024 that will close this issue
[#94] Expose invalid claims #95
Merged
18 tasks
shurwit added a commit that referenced this issue Feb 29, 2024
@shurwit @roberlander2
[#94] Expose invalid claims (#95)
64beb49 
* return invalid claims

* upgrade go and dependencies

* remove unused indirect dependencies

---------

Co-authored-by: Ryan Oberlander <reoberlander2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shurwit shurwit

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#94] Expose invalid claims rokwire/core-auth-library-go
1 participant
@shurwit