-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#523] Support for OAuth 2.0 Access Tokens #580
base: develop
Are you sure you want to change the base?
Conversation
…update bug, add examples to API docs [#523]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
…kwards compatibility
We would like to support the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @roberlander2, LGTM!
@petyos, I saw that you previously approved this but feel free to take a quick glance at the additional changes we made. Thanks!
Description
This PR adds support for generating ROKWIRE access tokens using OAuth 2.0 access tokens. It also fixes bugs related to application and organization cache updates and adds a
redirect_uri
field to identity provider configs.Resolves #523
Review Time Estimate
Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.
Type of changes
Please select a relevant option:
Checklist:
Please select all applicable options: