Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#523] Support for OAuth 2.0 Access Tokens #580

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from

Conversation

roberlander2
Copy link
Contributor

Description

This PR adds support for generating ROKWIRE access tokens using OAuth 2.0 access tokens. It also fixes bugs related to application and organization cache updates and adds a redirect_uri field to identity provider configs.

Resolves #523

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

  • Immediately
  • Within a week
  • When possible

Type of changes

Please select a relevant option:

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • I have updated the CHANGELOG.
  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@roberlander2 roberlander2 self-assigned this Aug 24, 2022
@roberlander2 roberlander2 linked an issue Aug 24, 2022 that may be closed by this pull request
petyos
petyos previously approved these changes Sep 20, 2022
Copy link
Collaborator

@petyos petyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@shurwit
Copy link
Collaborator

shurwit commented Jan 20, 2023

We would like to support the state param for OIDC as well. This should be added before we merge this PR.

shurwit
shurwit previously approved these changes Jan 31, 2023
Copy link
Collaborator

@shurwit shurwit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @roberlander2, LGTM!

@petyos, I saw that you previously approved this but feel free to take a quick glance at the additional changes we made. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support for OAuth 2.0 Access Tokens
3 participants