Fix crash on macOS when launching TACL a second time + fix dark theme support #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missed spotting this rather obvious mistake. Launching TACL-GUI twice on the same machine will lead to an error "File exists". Changed the relevant "exist_ok" option to True
Hardcoded white background clashes with dark system themes, which typically change the text color to white. Tested on macOS, but I suspect the same issue on other OS which dark themes, like Windows and Ubuntu.
|
@RandomByte Thank you again (also for the nice screenshots)! I tried it with Ubuntu, but the dark theme does not seem to affect the GUI as it does on Mac (it looks the same). Instead of changing the background color: does setting the text color explicitly to black (#000) also resolve this issue, or is the text color still white and unreadable? Unfortunately, I don't have a Mac and am not able test it by myself. If not, your solution would also be fine. |
|
Good idea! That looks rather decent with both themes 👍 Here it is in dark mode:
Updated the macOS build again here: https://www.dropbox.com/s/gmc6uvvtayowbfh/TACL-GUI.Darwin.zip?dl=0 |
|
Merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 1
Apparently I set the
exist_okflag for makedirs incorrectly, which leads to TACL-GUI crashing on macOS when launched a second time (since the directory already exists):Issue 2
In addition, we noticed that the labels in the "Database Info" component become unreadable when setting the system theme to "dark" (I highlighted the database path by selecting it with the cursor):
I suspect that the same issue shows on other OS' with dark themes, like Windows or Ubuntu. To resolve this quickly, I changed the label styling from setting a white background color to setting a border. But please feel free to implement a different solution!
I uploaded the ZIP-archive with the updated macOS build based on this PR again to my Dropbox: https://www.dropbox.com/s/gmc6uvvtayowbfh/TACL-GUI.Darwin.zip?dl=0