Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for python 2.6 (set syntax change) #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

njvack
Copy link

@njvack njvack commented Dec 10, 2015

Python 2.6 doesn't support {}-style set literals; replace it with the semantically-identical set([]) syntax.

This seems to fix CommonMark-py on Python 2.6

Addresses #24.

Python 2.6 doesn't support `{}`-style set literals; replace it with the semantically-identical `set([])` syntax.

This seems to fix CommonMark-py on Python 2.6
@ericholscher
Copy link

Looks good at first glance. If we want to commit to supporting 2.6 in the future, it should be added to the Travis configuration to test against going forward.

I'm +0 on officially supporting Python 2.6, as most of the ecosystem has moved on from this version. For instance, Django dropped 2.6 support in 1.7, which was released over a year ago. However, this is a pretty simple repo that likely won't need advanced features, so having broad version support isn't a huge issue.

@njvack
Copy link
Author

njvack commented Dec 10, 2015

Totally your call; I'm good either way as I'm packaging my own copy of this in my project:

https://github.com/njvack/markdown-to-json

... though until our center's servers all get upgraded, I do need to support 2.6.

nikolas pushed a commit to nikolas/commonmark.py that referenced this pull request Dec 10, 2015
@nikolas
Copy link

nikolas commented Dec 18, 2015

This change looks good, set() is supported in python3: https://docs.python.org/3/library/functions.html#func-set, so we should see no change in behavior, with the benefit of supporting another python version.
I agree with Eric about 2.6 - I'm not willing to put much work into supporting python 2.6 because it is deprecated.

You can make a pull request here: https://github.com/rtfd/CommonMark-py since rolandshoemaker's repository isn't being maintained.

@njvack
Copy link
Author

njvack commented Dec 18, 2015

OK, I've made a pull request at the new home.

It would be cool to somehow indicate prominently that this is not the canonical CommonMark-py repo.

@nikolas
Copy link

nikolas commented Dec 18, 2015

Yeah, I'm waiting on PR #23.. we should change the header at the top of this repo as well.

Unfortunately the maintainer here doesn't have the mental space to deal with any of this at the moment, so there's not much we can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants