Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for mainline #8

Merged
merged 4 commits into from
Apr 28, 2021

Conversation

foxel
Copy link
Contributor

@foxel foxel commented Apr 28, 2021

Some improvements from my side excluding the TTS adaptation:

  • binary sensors are now really binary
  • rtsp links are obtained from the camera, fixes issues with no high res stream
  • device info has connections defined so that it can merge with the same devices from other integrations
  • camera now supports stream integration

@foxel foxel force-pushed the improvements_for_mainline branch 3 times, most recently from b4f9507 to 576a64e Compare April 28, 2021 10:04
@foxel foxel force-pushed the improvements_for_mainline branch from 576a64e to 26ef096 Compare April 28, 2021 10:07
@roleoroleo roleoroleo merged commit 550ffb1 into roleoroleo:main Apr 28, 2021
@roleoroleo
Copy link
Owner

Thanks for your contribution!

@foxel foxel deleted the improvements_for_mainline branch April 28, 2021 12:41
@vin-w
Copy link
Contributor

vin-w commented Apr 28, 2021

I just updated to latest code with camera supports stream integration
then the live streaming in hass does not work (a blank white screen in the camera view)

Once I have removed the code below, the streaming works again for me.
Could we make this configurable?

    @property
    def supported_features(self) -> int:
        """Return supported features."""
        return SUPPORT_STREAM

@foxel
Copy link
Contributor Author

foxel commented Apr 28, 2021

@vin-w this piece of coffee just says that the camera is capable of providing a streaming URL.
You need to check that your HA stream integration works out disable it.
See requirements and details at https://www.home-assistant.io/integrations/stream/

@vin-w
Copy link
Contributor

vin-w commented Apr 29, 2021

@foxel Today I have fetched latest code + restarted the docker stack, it works now!
With the "Preload stream" checked, I don't have any more drop frame.

Thanks again for your code and make a happy home here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants