Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve argument checks #18

Merged
merged 10 commits into from
Sep 5, 2023
Merged

Improve argument checks #18

merged 10 commits into from
Sep 5, 2023

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Sep 5, 2023

@rolkra
Copy link
Owner

rolkra commented Sep 5, 2023

Great Work!
Just one thing that I recognised: fct_na_value_to_level() seems to add a new dependency to forcats 1.0.0 as this function seems to be introduced in 1.0.0. So this should be added to DESCRIPTION

@olivroy
Copy link
Contributor Author

olivroy commented Sep 5, 2023

@rolkra indeed, do you want me to add this to this PR?

Edit, did this in bf62ff0

@rolkra rolkra merged commit 897b4ab into rolkra:master Sep 5, 2023
5 checks passed
@olivroy olivroy deleted the rm-dep branch September 6, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants