-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DCC] Saves, Weapon Attacks, and other buttons missing modifiers #12132
Comments
Pinging @sturtus , since it's their commit :) |
Manually setting |
I don't have a Pro account anymore so I can't really test. Insane that Roll20 makes us pay to contribute to their product. |
I'm in the same boat 🤣 The most I can recommend is rolling back the change, which will at least take it back to a known more-functional state. |
I had a friend with Plus. Was able to test/fix and submitted a new PR.
…On Tue, Sep 5, 2023 at 8:48 PM Dave Bendit ***@***.***> wrote:
I'm in the same boat 🤣 The most I can recommend is rolling back the
change, which will at least take it back to a known more-functional state.
—
Reply to this email directly, view it on GitHub
<#12132 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPA37VUBSOEMNX7DVLS7G3XY7B7DANCNFSM6AAAAAA4MQVMYE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This got merged in and looks good to me. |
Confirmed, looks like the issue's resolved. Thanks! |
I'm assuming this is the source of the problem: 8a5f241
Buttons for the various saves and weapon attacks are missing the total modifier value and the values are missing from the "Attributes & Abilities" tab. Clicking those buttons rolls the saves, but no modifiers are included (shows
Rolling 1d20+ = (18)
). It's as if setting those fieldsreadonly
removed them from various Roll20 sheet functionality.The text was updated successfully, but these errors were encountered: