Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- fix: merge PR resolve #583 - Rollbar 4.0.2 crashes Xamarin.Forms-App #584

Merged
merged 3 commits into from
Mar 30, 2021
Merged

- fix: merge PR resolve #583 - Rollbar 4.0.2 crashes Xamarin.Forms-App #584

merged 3 commits into from
Mar 30, 2021

Conversation

akornich
Copy link
Contributor

@akornich akornich commented Mar 30, 2021 •
edited
Loading

Description of the change

  • fix: merge PR resolve Rollbar 4.0.2 crashes Xamarin.Forms-App #583 - Rollbar 4.0.2 crashes Xamarin.Forms-App
    the APIs we use to identify runtime directory vary their availability from one .NET flavor/version to another,
    as well as their behavior change based on .NET flavor/version. This fix uses safer implementation
    to take it all into account.

  • fixing a typo in HttpResponsePackageDecorator

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #583

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@akornich akornich added bug Denotes a runtime problem within the SDK dependencies Denotes issue involving external dependencies labels Mar 30, 2021
@akornich akornich added this to In progress in 2021-Q1 via automation Mar 30, 2021
@akornich akornich self-assigned this Mar 30, 2021
@waltjones waltjones self-requested a review March 30, 2021 18:38
waltjones
waltjones approved these changes Mar 30, 2021
View reviewed changes
Copy link

@waltjones waltjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

2021-Q1 automation moved this from In progress to Reviewer approved Mar 30, 2021
@akornich
Copy link
Contributor Author

@waltjones , thank you!

@akornich akornich merged commit b6cb249 into rollbar:master Mar 30, 2021
2021-Q1 automation moved this from Reviewer approved to Done Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waltjones waltjones waltjones approved these changes

Assignees

@akornich akornich

Labels
bug Denotes a runtime problem within the SDK dependencies Denotes issue involving external dependencies
Projects
2021-Q1
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rollbar 4.0.2 crashes Xamarin.Forms-App
2 participants
@akornich @waltjones