Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing VS build warnings and intelli-sense suggestions #599

Merged
merged 10 commits into from
Oct 13, 2021
Merged

Fixing VS build warnings and intelli-sense suggestions #599

merged 10 commits into from
Oct 13, 2021

Conversation

akornich
Copy link
Contributor

Description of the change

Fixing VS build warnings and intelli-sense suggestions

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix n/a

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@akornich
chore: cleaning up unused files in the repo root
6750530
@akornich
chore: cleaning unused files in the repo root
a8cdc97
@akornich
fix: [WIP] build warnings in Rollbar module
e53e81c
@akornich
fix: [CC] build warnings in Rollbar module
0a6c1aa
@akornich
fix: [CC] lear VS2022 build warnings and messages for the module - Ro…
a273925 
…llbar.NetCore.AspNet
@akornich
fix: [CC] clear VS2022 build warnings and messages for the module - R…
fa263a7 
…ollbar.Net.AspNet
@akornich
fix: [CC] clear VS2022 build warnings and messages for the module - R…
279f53f 
…ollbar.PlugIns.MSEnterpriseLibrary
@akornich
fix: [CC] clear VS2022 build warnings and messages for the module - R…
579fa98 
…ollbar.OfflinePersistence
@akornich
fix: [CC] clear VS2022 build warnings and messages for the module - B…
9f80467 
…enchmarker.Common
@akornich
chore: updated the version and the release notes
aa57ec4
@akornich akornich added enhancement Denotes SDK enhancement related task dependencies Denotes issue involving external dependencies refactoring Denotes codebase refactoring task build issue Denotes active build warning or error labels Oct 13, 2021
@akornich akornich self-assigned this Oct 13, 2021
@akornich akornich added this to In progress in 2021-Q4 via automation Oct 13, 2021
2021-Q4 automation moved this from In progress to Reviewer approved Oct 13, 2021
@akornich akornich merged commit 992c0b6 into rollbar:master Oct 13, 2021
2021-Q4 automation moved this from Reviewer approved to Done Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natesweet natesweet natesweet approved these changes

Assignees

@akornich akornich

Labels
build issue Denotes active build warning or error dependencies Denotes issue involving external dependencies enhancement Denotes SDK enhancement related task refactoring Denotes codebase refactoring task
Projects
2021-Q4
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akornich @natesweet