Add support to build person data for Starlette

rollbar/__init__.py

@@ -929,8 +929,12 @@ def _build_person_data(request):
         else:
             return None
 
-    # TODO: Check if AuthenticationMiddlawre installed for Startlette
-    if not StarletteRequest and hasattr(request, 'user'):
+    if StarletteRequest:
+        from rollbar.contrib.starlette.requests import hasuser
+    else:
+        hasuser = lambda request: False
+
+    if hasuser(request) and hasattr(request, 'user'):
         user_prop = request.user
         user = user_prop() if callable(user_prop) else user_prop
         if not user:

rollbar/contrib/starlette/requests.py

@@ -48,3 +48,10 @@ def store_current_request(
 
     _current_request.set(request)
     return request
+
+
+def hasuser(request: Request) -> bool:
+    try:
+        return hasattr(request, 'user')
+    except AssertionError:
+        return False

rollbar/test/starlette_tests/test_requests.py

@@ -74,3 +74,14 @@ def test_should_accept_scope_and_receive_params(self):
         request = store_current_request(scope, receive)
 
         self.assertEqual(request, expected_request)
+
+    def test_hasuser(self):
+        from starlette.requests import Request
+        from rollbar.contrib.starlette.requests import hasuser
+
+        request = Request({'type': 'http'}, {})
+        self.assertFalse(hasuser(request))
+
+        request = Request({'type': 'http', 'user': 'testuser'}, {})
+        self.assertTrue(hasuser(request))
+        self.assertEqual(request.user, 'testuser')