Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trace_chain to shortener_keys defaults #414

Closed
bisognano opened this issue Aug 10, 2022 · 2 comments
Closed

Add trace_chain to shortener_keys defaults #414

bisognano opened this issue Aug 10, 2022 · 2 comments
Assignees

Comments

@bisognano
Copy link

Hi! I was running into an issue wherein I was sending my locals to rollbar but getting the error

Failsafe from pyrollbar: payload too large. Original payload may be found in your server logs by searching for the UUID.

The solution was to add a new shortener_key to the config as

[("body", "trace_chain", "*", "frames", "*", "locals", "*")]

Looking at the defaults for shortener_keys for when locals.enabled is true, I would have anticipated trace_chain locals handling here as well.

[ ('body', 'trace', 'frames', '*', 'code'), ('body', 'trace', 'frames', '*', 'args', '*'), ('body', 'trace', 'frames', '*', 'kwargs', '*'), ('body', 'trace', 'frames', '*', 'locals', '*') ]

Would it be reasonable to add that trace_chain tuple to the defaults on shortener_chain as well? Looks like theres a stagnant open PR for this currently - #365

@danielmorell danielmorell self-assigned this Oct 5, 2022
@danielmorell
Copy link
Collaborator

Hi @bisognano, sorry for the delay on this. I think this sounds like a reasonable default. I will take a look at #365.

@danielmorell
Copy link
Collaborator

This was resolved when #365 was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants