Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing locals shortening on items with "trace_chain" instead of "trace" #365

Conversation

terencehonles
Copy link
Contributor

@terencehonles terencehonles commented Jan 26, 2021

Description of the change

In addition to shortening trace, trace_chain should also be shortened (and not cause a logged error about the payload being too large).

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@terencehonles terencehonles changed the title fix missing locals shortening to items with "trace_chain" instead of "trace" fix missing locals shortening on items with "trace_chain" instead of "trace" Jan 26, 2021
@terencehonles terencehonles force-pushed the fix-trace_chain-missing-from-shortener_keys branch from 8367040 to 33c330b Compare January 26, 2021 01:43
@danielmorell danielmorell self-assigned this Oct 5, 2022
@danielmorell danielmorell self-requested a review October 5, 2022 11:22
@danielmorell
Copy link
Collaborator

Hey @terencehonles, sorry this sat idle for so long. Locally I merged this with our master branch and ran our test suite and everything passed. I would like to run the whole test suite including frameworks against this again since there have been a lot of commits since this PR was created.

Can you pull the latest from master into your branch? This should trigger a rerun of the entire test suite.

I also will take a closer look at it gets reviewed by anyone else who needs to.

@jmarronm
Copy link

@danielmorell can we review this PR and consider closing or merging it , please?

Copy link
Collaborator

@danielmorell danielmorell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @terencehonles! This looks good!

@danielmorell danielmorell merged commit 853ee85 into rollbar:master Apr 28, 2023
@terencehonles
Copy link
Contributor Author

Sorry I didn't see your previous message, glad this moved forward 🙂

@terencehonles terencehonles deleted the fix-trace_chain-missing-from-shortener_keys branch May 3, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants