Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses errors when request has no META attribute #273

Merged
merged 1 commit into from
Jul 13, 2018

Conversation

rgs258
Copy link
Contributor

@rgs258 rgs258 commented Jun 20, 2018

This corrects a bug that can cause errors when the request has no META attribute

@rivkahstandig3636
Copy link
Contributor

Thanks for this! Looks good to me but I'd like to have our SDK engineer check it out.

@rokob
Copy link
Contributor

rokob commented Jun 20, 2018

Do you have an instance of a Django request with no META attribute? The documentation (https://docs.djangoproject.com/en/1.11/ref/request-response/#django.http.HttpRequest.META) specifies that META should exist. There isn't anything fundamentally wrong with this hasattr check but it should be unnecessary.

@rgs258
Copy link
Contributor Author

rgs258 commented Jun 21, 2018 via email

@rgs258
Copy link
Contributor Author

rgs258 commented Jun 27, 2018

Bump

@rokob rokob merged commit 7a61945 into rollbar:master Jul 13, 2018
@brianr
Copy link
Member

brianr commented Aug 8, 2018

Released in 0.14.2

@rgs258 rgs258 deleted the fix-meta-bug branch August 8, 2018 18:58
@rgs258 rgs258 restored the fix-meta-bug branch August 8, 2018 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants