fix exceptions in wrapped rest_framework exception handler #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The request data is not guaranteed to be available in the exception handler, so this wraps the assignment to safely access the data. - The import path could still result in a call to ``None``, this changes the handler to detect ``None`` and raise either a django ImproperlyConfigured or RuntimeError depending what is available.
terencehonles
force-pushed
the
fix-django-rest-framework-exception-handler
branch
from
f57129d
to
dcee846
Compare
waltjones
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The request data is not guaranteed to be available in the exception handler, so this wraps the assignment to safely access the data.
The import path could still result in a call to
None, this changes the handler to detectNoneand raise either a django ImproperlyConfigured or RuntimeError depending what is available.Fixes: #314