-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin Werkzeug version for Flask 0.x #376
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On May 11, 2021 Jinja2 released a new major version 3.x that is not compatible with older Flask versions.
This pull request has been linked to Clubhouse Story #85391: [CI] Flask v0.x has started to fail on Python3.5+. |
10 tasks
Looks it should work for Werkzeug <2.0 (at least we successfully built with 1.0.1), however pining it to <2.0 similar to the upstream fix.
Backporting from the upstream
diegov
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
On May 11, 2021, Werkzeug released a new 2.x version that are not compatible with Flask 0.x.
This PR pins compatible Werkzeug version to Flask 0.x to fix build issues:
NOTE: We have successfully built
Flask 0.x
withWerkzeug 1.x
so far, however according to the upstream,Flask 0.x
requiresWerkzeug >=0.7 and < 1.0
, so for sanity this PR uses the same requirements.Type of change
Related issues
[ch85391]
Checklists
Development
Code review