Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Move user provided extra data under custom (#431)" #434

Merged

Conversation

arpad-fulop-rb
Copy link
Contributor

Description of the change

This PR reverts the changes in commit e3e1595, except for the version tag. We decided we won't need these changes.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Shortcut stories and GitHub issues (delete irrelevant)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

This reverts commit e3e1595,
Except for the version tag. We decided we won't need these changes.

Signed-off-by: Arpad Fulop <arpad.fulop@rollbar.com>
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #129187: Revert extra data changes in pyrollbar.

Copy link

@Bandoca Bandoca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@arpad-fulop-rb arpad-fulop-rb merged commit ed8f2a6 into master Aug 8, 2023
97 checks passed
@arpad-fulop-rb arpad-fulop-rb deleted the af/sc-129187/revert-changes-in-extra-data-handling branch August 8, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants