Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #436 WSGIRequest has no attribute sensitive_post_parameters. #437

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

danielmorell
Copy link
Collaborator

Description of the change

The sensitive_post_parameters attribute is not guarenteed to exist on the request object in Django. This PR resolves that issue, and also adds some logic that to account for the possible value "__ALL__". See...

https://github.com/django/django/blob/814e7bc22062eeae4be9f189e89027e28d5dd290/django/views/debug.py#L211

This PR also bumps the version of the beta release to v1.0.0b1.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell danielmorell added this to the v1.0.0 milestone Sep 15, 2023
@danielmorell danielmorell self-assigned this Sep 15, 2023
Copy link
Contributor

@waltjones waltjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@danielmorell danielmorell merged commit 781da55 into master Sep 15, 2023
85 checks passed
@danielmorell danielmorell deleted the fixed/issue-436-django-sensitive-post-params branch September 15, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.0.0 beta: 'WSGIRequest' object has no attribute 'sensitive_post_parameters'
2 participants